- cross-posted to:
- [email protected]
- cross-posted to:
- [email protected]
You must log in or register to comment.
Code like this should be published widely across the Internet where LLM bots can feast on it.
Y’all laugh but this man has amazing code coverage numbers.
You could use a loop to subtract 2 from the number until it equals one or zero
Or literally just look at its binary representation. If the least significant digit is a “1”, it’s odd, if “0”, it’s even. Or you can divide by 2 and check for a remainder.
Your method is just spending time grinding away CPU cycles for no reason.
Sorry we’re not all fucking math nerds like you who knows words like “significant” or “binary” or “divide”, Poindexter. Some of us make do with whatever solution is available!
We know you were being satire. IMO it is of decent manner if you add “/s” to be explicit so when responding a serious reply, because this is not a satire comment chain.
Sorry we’re not all fucking satire nerds like you who knows words like “serious” or “satire” or “/s”, Poindexter. Some of us make do with whatever solution is available!
Wasn’t the fun the CPU cycles we wasted along the way?
are you my TA that I mentioned in the other comment
Maybe. And I can’t blame it on not having had coffee when I made the comment. Just me being completely oblivious to a joke.
What should all the non binary people do then you bigot
Ffs just use a switch. It’s much faster!
A decent compiler will optimize this into
return maybe;ftfy
bool IsEven(int number) { return !IsOdd(number); } bool IsOdd(int number) { return !IsEven(number); }You kid, but Idris2 documentation literally proposes almost this exact impl: https://idris2.readthedocs.io/en/latest/tutorial/typesfuns.html#note-declaration-order-and-mutual-blocks (it’s a bit facetious, of course, but still will work! the actual impl in the language is a lot more boring: https://github.com/idris-lang/Idris2/blob/main/libs/base/Data/Integral.idr)
I hadn’t seen Idris2. Thank you for providing me with a new rabbit hole!
I’m glad to tell more people about it. It’s really quite amazing (I could write a somewhat complex algorithm and prove some properties about it in a couple afternoons, despite limited formal verification experience) and I’m sure that in 20 odd years the ideas behind it will make it into mainstream languages, just as with ML/Haskell.
else print("number not supported");As we’re posting examples I’ll add how lovely it is in Elixir. Elixir def not putting the fun in programmer memes do. One reason I picked it because I can’t be trusted to not be the meme.
def is_even?(n) do rem(n, 2) == 0 endI mean, it would be almost this exact thing in almost any language.
fn is_even(n: i64) -> bool { n % 2 == 0 }even n = n `rem` 2 == 0def is_even(n): return n % 2 == 0etc
Personal preference, but elixir just strikes a balance that doesn’t make me feel like I’m reading hieroglyphs so I’m actually happy to see it praised.
I would have preferred for the function to be called mod, since it’s the modulo operation, which in math is represented with a percentage or “mod”. Most programming languages use a percentage because of that, so do a lot of calculators.
Yeah, I agree that Elixir is a fine language for some tasks. I personally find the readability somewhat average, but it’s very maintainable (due to how it enables clear program structure), the error handling is great, and the lightweight process system is amazing.
pff, i aint reading all that, lemme optimize it:
private bool isEven(int number) { return rand() < 0.5; }No, no, you should group the
return falselines together 😤😤if (number == 1) return false; else if (number == 3) return false; else if (number == 5) return false; //... else if (number == 2) return true; else if (number == 4) return true; //...IMO he’s ragebaiting
OP is. This is just a remix of a popular meme.
I think he’s leaning into the drama for attention, but he’s also just bad
Photoshopping Thor over top of old programming horror posts is diabolical lmao
This is why this code is good. Opens MS paint. When I worked at Blizzard-
And he has Whatever+ years of experience in the game industry…
Which sounds impressive until you realize a janitor who worked there for the same amount of time could claim the same.
That code is so wrong. We’re talking about Jason “Thor” Hall here—that function should be returning 1 and 0, not booleans.
If you don't get the joke...
In the source code for his GameMaker game, he never uses
trueorfalse. It’s always comparing a number equal to 1.Frankly, it’s what I did, too, after coming out of Uni-level C.
My code was goddamn unreadable.
It’s the same for a lot of people. Beginners are still learning good practices for maintainable code, and they’re expected to get better over time.
The reason people are ragging on PirateSoftware/Jason/Thor isn’t because he’s bad at writing code. It’s because he’s bad at writing code, proclaiming to be an experienced game development veteran, and doubling down and making excuses whenever people point out where his code could be better.
Nobody would have cared if he admitted that he has some areas for improvement, but he seemingly has to flaunt his overstated qualifications and act like the be-all, end-all, know-it-all of video game development. I’m more invested in watching the drama unfold than I should be, but it’s hard not to appreciate the schadenfreude from watching arrogant influencers destroy their reputation.
He’s totally one of those people that’s sort of attractive and has an authoritative voice so s lot of people have probably folded to him in arguments through his life. I don’t like making generalizations like that about people but this isn’t the first time he’s acted like this. The one that really took the cake was the whole hardcore WoW raid debacle.
The TL;DR is, as well as not trying to really spend time on the parts that don’t matter, he did some things that may or may not have been the right thing to do in the situation depending on your perspective. But whenever any of his guild mates or other viewers would criticize him he’d be so adamant that no, he didn’t do anything wrong, he did exactly what he was supposed to do, etc. People would even explicitly tell him “hey, what’s pissing us off now isn’t that you did it, it’s that you’re so adamant you couldn’t have possibly made a mistake, you’re not willing to see our perspective. You’re not willing to admit that maybe you could’ve been wrong. You’re not willing to apologize.” And still, his reaction to this was to triple down and just insist he didn’t do anything wrong.
Like I literally even saw a clip of him talking to someone and he said “a lot of people think I’m being condescending when really I’m just providing context.” And the guy talking to him points out “yeah, it’s a problem that you think anyone disagreeing with you doesn’t understand the situation, it’s like you think they’re stupid.” It’s like it short circuited his brain. It’s like he’d never considered it.
So yeah, I have a pretty low opinion of him. But I also recognize that maybe all these clips are taken out of context, who knows. It’s not like my opinion really matters. I don’t work with him or know him. I don’t care about streamers. I don’t really watch them.
I am working with C in embedded designs and I still use 1 or 0 for a bool certain situations, mostly lines level.
For whatever pea-brained reason, it feels yucky to me to set a gpio to true/false instead of a 1/0.
GPIOs are usually controlled by a single bit of a register anyway. Most likely you need to do something like:
// Set high PORTB |= 1 << PINB5; // Set low PORTB &= ~(1 << PINB5);I am a lazy dev (not really, clients always want fast code), so I use the provided HAL libraries 99.9% of the time.
But I have seen code where someone would write something like
gpio_write(PIN_X, true)and it always stood out to me.
Define on as true or something? Or maybe that’s more confusing. I’m not a C dev so I’m not gonna pretend to understand idiomatic microcontroller code lol.
Sometimes, people do that. But using 0/1 is explicit enough since you can refer to a line as ‘1’ or ‘0’ for high/low on the hardware as well
This is what Test Driven Development looks like
TDD has cycles of red, green, refactor. This has neither been refactored nor tested. You can tell by the duplication and the fact that it can’t pass all test cases.
If this looks like TDD to you, I’m sorry that is your experience. Good results with TDD are not guaranteed, you still have to be a strong developer and think through the solution.
When you say “it can’t pass all test cases”, what do you imagine the tests look like?
In a world where this needs to be solved with TDD there are a few approaches.
If you were pair programming, your pair could always create a new failing test with the current implementation.
Realistically I would want tests for the interesting cases like zero, positive even, negative even, and the odds.
Another approach would be property based testing. One could create sequence generators that randomly generate even or odd numbers and tests the function with those known sequences. I don’t typically use this approach, but it would be a good fit here.
Really in pair programming, your pair would get sick of your crap if you were writing code like this, remind you of all the work you need to get done this week, and you’d end up using modulus and move on quickly.
you’d end up using modulus and move on quickly.
But where’s the fun in that?
There are so many better
for obfuscationways of checking for oddness!(a & 1) > 0 a.toString()[a.toString().length()-1] - '1' == 0 iseven(a)?(1==0):(1!=0)If you were pair programming, your pair could always create a new failing test with the current implementation.
But I’m not pair programming. And you can’t always create a new failing test because
intis a finite type. There are only about 4 billion cases to handle.Which might take a while to type up manually, but that’s why we have meta-programming: Code that generates code. (In C++ you could even use templates, but you might run into compiler recursion limits.)
More to the point, the risk with TDD is that all development is driven by failing test cases, so a naive approach will end up “overfitting”, producing exactly the code required to make a particular set of tests pass and nothing more. “It can’t pass all test cases”? It doesn’t have to. For TDD, it only needs to pass the tests that have actually been written. You can’t test all combinations of all inputs.
(Also, if you changed this function to use modulus, it would handle more cases than before, which is a change in behavior. You’re not supposed to do that when refactoring; refactoring should preserve semantics.)
Read the article about property based testing. It is the middle ground between what you are describing and practicality.
I often pair with myself, which sounds silly but you can write failing tests by yourself, it just isn’t as fun.
As the existing reply stated, there are only ever finitely many tests.
My issue with TDD is that it pretends to drive the final implementation with tests, but what is really driving the implementation is the monkey at the keyboard thinking, “testing for evenness should be done with the modulo operation,” not exhaustive tests.
The monkey at the keyboard thinking is what software development is. When faced with a failing test, you make it pass as simply as possible, and then you summon all your computer science / programming experience to refactor the code into something more elegant and maintainable.
In this case that is using math to check if the input is divisible by two without a remainder. If you don’t know how that works, you’re going to have a bad time, like the picture in this post.
TDD doesn’t promise to drive the final implementation at the unit level, but it does document how the class under test behaves and how to use it.
When faced with a failing test, you make it pass as simply as possible, and then you summon all your computer science / programming experience to refactor the code into something more elegant and maintainable.
Why bother making it pass “as simply as possible” instead of summoning all that experience to write something that don’t know is stupid?
TDD doesn’t promise to drive the final implementation at the unit level
What exactly does it drive, then? Apart from writing more test code than application code, with attendant burdens when refactoring or making other changes.
The rhythm of TDD is to first write a failing test. That starts driving the design of your production code. To do that you need to invoke a function/method with arguments that responds with an expected answer.
At that point you’ve started naming things, designing the interface of the unit being tested, and you’ve provided at least one example.
Let’s say you need a method like
isEven(int number): Boolean. I’d start with asserting 2 is even in my first test case.To pass that, I can jump to
number % 2 == 0. Or, I can just returntrue. Either way gets me to a passing test, but I prefer the latter because it enables me to write another failing test.Now I am forced to write a test for odd input, so I assert 3 is not even. This test fails, because it currently just returns
true. Now I must implement a solution that handles even and odd inputs correctly; I know modulus is the answer, so I use it now. Now both tests pass.Then I think about other interesting cases: 0, negative ints, integer max/min, etc. I write tests for each of them, the modulus operator holds up. Great. Any refactoring to do? Nope. It’s a one-liner.
The whole process for this function would only add a few minutes of development, since the implementation is trivial. The test runtime should take milliseconds or less, and now there is documentation for the next developer that comes along. They can see what I considered (and what I didn’t), and how to use it.
Tests should make changing your system easier and safer, if they don’t it is typically a sign things are being tested at the wrong level. That’s outside the scope of this lemmy interaction.
Either way gets me to a passing test, but I prefer the latter because it enables me to write another failing test.
But you could just write that failing test up front. TDD encourages you to pretend to know less than you do (you know that testing evenness requires more than one test, and you know the implementation requires more than some if-statements), but no-one has ever made a convincing argument to me that you get anything out of this pretence.
Tests should make changing your system easier and safer, if they don’t it is typically a sign things are being tested at the wrong level
TDD is about writing (a lot of) unit tests, which are at a low-level. Because they are a low-level design-tool, they test the low-level design. Any non-trivial change affects the low-level design of a component, because changes tend to affect code at a certain level and most of those below it to some degree.
Unittest in Python, enjoy! If you pass it with a function like the one in OPs picture, you have earned it.
import unittest import random class TestOddEven(unittest.TestCase): def test_is_odd(self): for _ in range(100): num = random.randint(-2**63, 2**63 - 1) odd_num = num | 1 even_num = num >> 1 << 1 self.assertTrue(is_odd(odd_num)) self.assertFalse(is_odd(even_num)) def test_is_even(self): for _ in range(100): num = random.randint(-2**63, 2**63 - 1) odd_num = num | 1 even_num = num >> 1 << 1 self.assertTrue(is_even(even_num)) self.assertFalse(is_even(odd_num)) if __name__ == '__main__': unittest.main()I don’t want unseeded randomness in my tests, ever.
Seed the tests, and making these pass would be trivial.
The right tool for the right job ¯\(ツ)/¯
The right tool here is tests at a level higher than machine code instructions that have been in CPUs since the 70s. Maybe TDD practice is not to test at this level, but every example of TDD sure tends to be something similar!
YanDev: “Thank God I’m no longer the most hated indie dev!”
YanDev is a literal pedophile. It’s honestly mind boggling people care more about a guy who won’t sign a petition on preserving video games than pedophiles and bigots. I don’t get the hate.
it’s not that he “wont sign it”. lmao. its that he comoketely unprovoked started a hate campaign against it, literally on the spot hearing about it on stream, directed his viewers not to engage with the petition and started making up a bunch of reasons while talking in that confident-but-clulesss voice about how its destructive and awful and short sighted, making up a bunch of atuff about it that was immediately disproven, just spewing all this vitriol for no reason. Not engaging with it is one thing but actively fighting against a wonderul consumer rights campaign like this, not to mention how important iy is to gaming history to be able to preserve games, is so anti-gamer i dont understand how he ever got a following. Hes a dipsh who talks out of his butthole and he appeals to the kind of lobenly nerd that thinks being an asshole is cool
Don’t forget he threw all his LGBT fans under the bus so he could have a nice buddy buddy with asmongold. Resulting in his community being invested with asmongold’s hateful degen followers, calling his LGBT fans horrific slurs.
But hey! Atleast he was able to defend the game Ashes of Creation or whatever its called against asmonshit…
Then when fans called him out, he went “Just cancel me, i guess…” fucking manchild…
Random website but just for a article that gives a summary of what happened: https://www.sportskeeda.com/us/streamers/news-i-again-pirate-software-defends-collaboration-asmongold-amid-backlash-fans
He uses multiple times insults that you’d hear from a teen. He’s not funny, not clever, has limited communication skills ans generally speaking unlikable. He’s not a role model, stay away from these.
Pirate Software is also a big liar, and a bad dev, who couldn’t finish his game in 8 years.
Because this dumbass has existed for a lot longer than the single moment you are using to construct the strawman of “the enraged internet user over nothing other than a ‘petition’ (HUGE mischaracterization, he’s not eligible to sign in anyway)” and just like when yanderedev was finally widely controversial, the “yanderedev code is bad lol” memes and jokes were very popular.
Can you at least pretend you understand how “the continuous flow of time works” before you post the dumbest shit ever?
Even this comment is filled with hatred. Why are you so angry?
He’s always been a deceitful and manipulative narcissist, even before being an industry plant anti-consumer shill.
Here’s a good one, the time he manipulated someone a decade younger than him for money and sex via furry roleplay while hiding the fact he was married: https://piratesoftware.sucks/
Post dumb reply = angry reply back
